utils_libvirt/libvirt_disk: add function to get disk by serial #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chunfuwen Please help review. |
chunfuwen
reviewed
Dec 8, 2023
| that's not mounted currently. | ||
|
|
||
| :param session: VM session | ||
| :param test: Test instance |
There was a problem hiding this comment.
here there is no test parameter, others LGTM
There was a problem hiding this comment.
Thanks for spotting it, fixed.
smitterl
force-pushed
the
get_new_disk
branch
from
4d8c348 to
08a2e6b
Compare
|
There might be an issue with this. Setting draft until I have confirmed it works also when the first item is the searched-for disk. |
smitterl
force-pushed
the
get_new_disk
branch
from
08a2e6b to
22ab95d
Compare
Use the SERIAL to identify a disk and return its path. Suggested-by: Chunfu Wen <[email protected]> Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
get_new_disk
branch
from
22ab95d to
5120c2a
Compare
smitterl
changed the title
|
@chunfuwen There was a problem with my implementation. At some point the 'new_disk' might also have been mounted during the tests. So, here I changed the patch to identifying with the serial as proposed by you autotest/tp-libvirt#5323 (comment) Please can you review again? |
|
Using the serial doesn't work for LUNS: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the SERIAL to identify a disk and return its path.
Suggested-by: Chunfu Wen [email protected]
Signed-off-by: Sebastian Mitterle [email protected]
Used in autotest/tp-libvirt#5323